Skip to content

feat: test multiple substrait versions in ci #151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
tokoko wants to merge 1 commit into from
Closed

feat: test multiple substrait versions in ci #151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ name: Run tests
on:
pull_request:
push:
branches: [ main ]
tags: [ 'v*.*.*' ]
branches: [main]
tags: ["v*.*.*"]

permissions:
contents: read
Expand All @@ -16,6 +16,7 @@ jobs:
matrix:
os: [macos-latest, ubuntu-latest, windows-latest]
python: ["3.10", "3.11", "3.12", "3.13"]
substrait_version: ["0.78.0", "0.79.0"]
Copy link
Member

@vbarua vbarua Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the benefit of testing multiple substrait versions?

Copy link
Contributor Author

@tokoko tokoko Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm assuming we'll eventually have some sort of a policy regarding supported substrait versions. This would ensure changes don't accidentally break compatibility with older substrait versions. if you think that's premature, we can forget about it for now, at least until version 1.

Copy link
Member

@vbarua vbarua Feb 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's a bit premature tbh. We actually just talked a bit at the last sync about starting to remove some deprecated features/fields, and a check like this would potentially add some friction to that.

runs-on: ${{ matrix.os }}
steps:
- name: Checkout code
Expand All @@ -28,4 +29,4 @@ jobs:
python-version: ${{ matrix.python }}
- name: Run tests
run: |
uv run --frozen pytest
uv run --frozen --with substrait-protobuf==${{ matrix.substrait_version }} pytest
Loading