Improved initial guess for Newton solver in data-driven fluid model#2734
Merged
EvertBunschoten merged 7 commits intodevelopfrom Feb 20, 2026
Merged
Improved initial guess for Newton solver in data-driven fluid model#2734EvertBunschoten merged 7 commits intodevelopfrom
EvertBunschoten merged 7 commits intodevelopfrom
Conversation
…data-driven fluid model
… in Newton solver processes
…prevent Newton solver processes from getting stuck on bounds of the lookup algorithm
pcarruscag
reviewed
Feb 19, 2026
pcarruscag
reviewed
Feb 19, 2026
Member
pcarruscag
left a comment
There was a problem hiding this comment.
Are there no tests using the data-driven models? I was expecting this change to trigger some regression changes.
Maybe the Newton solves had no issues with the regressions?
Member
Author
Yes the existing data-driven regression test happened to run just fine with the previous initialization method. However, I experienced issues when running some more challenging turbomachinery cases that use the Giles BC. |
pcarruscag
approved these changes
Feb 19, 2026
Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
The data-driven fluid model uses a Newton algorithm to calculate thermodynamic states for thermodynamic pairs different from density + internal energy. The initial guess for the Newton algorithm was determined through additional settings in the configuration file or by approximation with the ideal gas law.
However, these methods do not always provide an initial guess sufficiently close to the target to get the Newton algorithm to converge, especially for non-reflective boundary conditions. I have added two features which address this problem:
PR Checklist
Put an X by all that apply. You can fill this out after submitting the PR. If you have any questions, don't hesitate to ask! We want to help. These are a guide for you to know what the reviewers will be looking for in your contribution.
pre-commit run --allto format old commits.