Fix mqtt client not have the consumer metric#2056
Open
Technoboy- wants to merge 1 commit intomasterfrom
Open
Conversation
|
@Technoboy-:Thanks for your contribution. For this PR, do we need to update docs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Message consumption is not reflected in the subscription and consumer stats when using a MQTT client.
Scenario: MQTT consumer subscribes to topic and starts consuming messages.
Expected: msgOutCounter, bytesOutCounter etc. under the MQTT subscription (and consumer) increase as messages are consumed.
Besides the message consumption stats, it would be great to have the clientVersion at least hard-coded to mqtt, similar to how the Kafka adapter does, as well as passing the appId.
Here is the example:
Documentation
Check the box below.
Need to update docs?
doc-required(If you need help on updating docs, create a doc issue)
no-need-doc(Please explain why)
doc(If this PR contains doc changes)