gather data from user submitted long_call.txt files#1695
Draft
sandboxcoder wants to merge 1 commit into
Draft
Conversation
424475a to
0907c47
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Adds a standalone TypeScript utility under profile-long-calls/ to download user-cache zips from S3, extract long_calls.txt, ingest the data into a local SQLite DB, and print aggregate “worst offender” IPC-call performance reports.
Changes:
- Introduces
long-calls-analyzer.ts(S3 listing/download, zip extraction, SQLite ingest, and reporting). - Adds local tooling/config for building/running/debugging the analyzer (tsconfig, package.json, VS Code launch config, Yarn config).
- Updates
.gitignoreto exclude build output (dist/) and the generated SQLite DB.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 9 comments.
Show a summary per file
| File | Description |
|---|---|
| profile-long-calls/tsconfig.json | TypeScript compiler config for building the analyzer into dist/. |
| profile-long-calls/README.md | Documents purpose and usage for the analyzer. |
| profile-long-calls/package.json | Declares dependencies and run/build scripts for the analyzer. |
| profile-long-calls/long-calls-analyzer.ts | Core implementation: S3 fetch, unzip, SQLite ingest, and stats output. |
| profile-long-calls/.yarnrc.yml | Yarn configuration for installing/running the tool in this subfolder. |
| profile-long-calls/.vscode/launch.json | Debug configuration for running the analyzer with ts-node. |
| .gitignore | Ignores generated analyzer artifacts (dist/, SQLite DB files). |
Comments suppressed due to low confidence (1)
profile-long-calls/long-calls-analyzer.ts:396
- Same as above:
affected_usersis computed asCOUNT(DISTINCT source_id), which counts sources/zips rather than users. If the output is intended to be per-user, joinsourcesand count distinctusername(handling NULLs appropriately) or rename the output to avoid implying it’s user count.
`SELECT
call_name,
SUM(is_freeze) AS freezes,
COUNT(DISTINCT source_id) AS affected_users,
MAX(total_ms) AS max_ms,
ROUND(AVG(total_ms)) AS avg_ms
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
* Analyzes the long_calls.txt file produced by obs-studio-node and helps identify which methods takes the longest. * Asana: https://app.asana.com/1/1083097041131/project/1207748235152476/task/1214564097102925
41a9a46 to
a73522d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Check user submitted logs to AWS S3 bucket and generate a report.
How Has This Been Tested?
Ran it manually over a 24 hour period.
Types of changes
Checklist: