Prevent temp file swapping in tx edit command.#2521
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR hardens the stellar tx edit workflow by moving the editable JSON into a private temporary directory (instead of the current working directory), preventing unsafe temp-file behaviors (including swap/replace risks) while editing.
Changes:
- Create the edit buffer file inside a
tempfile::TempDirand keep the directory alive for the duration of the command. - Apply restrictive permissions on Unix (dir
0700, file0600). - Add unit tests to verify tempdir usage and (on Unix) permission constraints.
leighmcculloch
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Prevent temp file swapping in tx edit command.
Why
Close https://github.com/stellar/stellar-cli-internal/issues/54
Known limitations
N/A