fix: propagate API_SUFFIX wrappers and complex-number docs wording#11952
Open
Planeshifter wants to merge 2 commits intodevelopfrom
Open
fix: propagate API_SUFFIX wrappers and complex-number docs wording#11952Planeshifter wants to merge 2 commits intodevelopfrom
API_SUFFIX wrappers and complex-number docs wording#11952Planeshifter wants to merge 2 commits intodevelopfrom
Conversation
Propagates fixes from a65e1fd ("fix: add suffix wrappers and replace inline NaN literal") and 8516750 ("fix: add missing suffix wrappers") to sibling packages whose `API_SUFFIX`-wrapped routines call other `API_SUFFIX`-wrapped strided routines without the macro. Affected packages: - `blas/ext/base/snansumpw` - `blas/ext/base/ssumpw` - `stats/strided/dsempn` - `stats/strided/dsmeanpn` - `stats/strided/dsvariancepn` - `stats/strided/dztest` - `stats/strided/dztest2` - `stats/strided/sztest` - `stats/strided/sztest2`
Propagates fixes from b0713ea ("docs: update descriptions to be consistent with elsewhere in project") and a3a5677 ("docs: follow-up fixes") to test descriptions that still use the reverse word order "complex {single,double}-precision floating-point". Project canonical wording is "{single,double}-precision complex floating-point", which matches the JSDoc in each package's `lib/main.js`. Affected packages: - `complex/float32/base/assert/is-almost-equal` - `complex/float32/base/assert/is-almost-same-value` - `complex/float64/base/assert/is-almost-equal` - `complex/float64/base/assert/is-almost-same-value`
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Propagating fixes merged to
developbetween 2026-05-04 17:00 EDT and 2026-05-05 03:03 PDT to sibling packages.fix:— MissingAPI_SUFFIX(...)wrappers around internal_ndarraycalls (a65e1fd, 8516750)Internal calls to
API_SUFFIX-decorated strided ndarray routines were made using bare symbol names (e.g.,stdlib_strided_drss_ndarray(...)instead ofAPI_SUFFIX(stdlib_strided_drss_ndarray)(...)). When the project is built with a non-empty CBLAS integer suffix, the bare name is an undefined symbol, causing link failure; the bug is silent only when the suffix is empty. Affected packages span pairwise summation helpers with self-recursive_ndarraycalls and z-test and variance routines delegating to sibling_ndarrayentry points.blas/ext/base/snansumpwblas/ext/base/ssumpwstats/strided/dsempnstats/strided/dsmeanpnstats/strided/dsvariancepnstats/strided/dzteststats/strided/dztest2stats/strided/szteststats/strided/sztest2docs:— Word order: "{single,double}-precision complex floating-point" (b0713ea, a3a5677)tape(...)descriptions in four assert packages used the reversed form "complex {single,double}-precision floating-point" rather than the canonical "{single,double}-precision complex floating-point" established across the rest of the project. The fix propagates the word-order correction from b0713ea and a3a5677, bringing the test descriptions into agreement with each package's ownlib/main.jsJSDoc.complex/float32/base/assert/is-almost-equalcomplex/float32/base/assert/is-almost-same-valuecomplex/float64/base/assert/is-almost-equalcomplex/float64/base/assert/is-almost-same-valueRelated Issues
None.
Questions
None.
Other
Validation. Each candidate site was searched via ripgrep across
lib/node_modules/@stdlib/, scoped to the namespaces in which the source commits originated (stats/strided/*,blas/ext/base/*,complex/float{32,64}/base/assert/*). Two independent validation passes confirmed (a) the calling function is itselfAPI_SUFFIX-wrapped at its definition, (b) the called function's definition usesAPI_SUFFIX(...), and (c) the bare-name call lies inside the wrapped function body. A separate adaptation pass produced the per-site mechanical patch and a style-consistency pass confirmed each replacement matches the surrounding file's spacing and call conventions.Deliberately excluded. Calls to
stdlib_strided_stride2offsetwere not wrapped — the function's definition is unsuffixed, so wrapping its call sites would produce undefined symbols (~390 ripgrep hits dropped on this basis). Sites flaggedneeds-humanby any agent were dropped. Adaptive fixes requiring cross-package edits were dropped. Thedocs: restore section template comments(86e9aee) andrefactor: merge two-condition argument-validation blocks(79dedda) commits were not propagated — neither produces a generalizable search signature without risking subtle regressions.Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was authored by Claude Code as part of an automated fix-propagation routine. Source commits were identified within the last 24 hours on
develop, fix patterns specified, candidate sites validated independently by two reviewers and a style-consistency pass, and patches applied mechanically. A maintainer should review before merging.@stdlib-js/reviewers
Generated by Claude Code