chore: minor clean-up#11951
Open
Planeshifter wants to merge 9 commits intodevelopfrom
Open
Conversation
Contributor
Coverage Report
The above coverage report was generated for the changes in this PR. |
Planeshifter
commented
May 5, 2026
Planeshifter
commented
May 5, 2026
Planeshifter
commented
May 5, 2026
…view Reverts: - 0f14066 (operator spacing in `_tools/eslint/rules/line-closing-bracket-spacing`) - 8634b93 (`cscal`/`gscal` in `blas/base/ndarray` namespace types) - fa775c5 (`dcorrelation` in `stats/strided/distances` namespace types) Namespace TS declarations are auto-generated and should not be hand-edited. https://claude.ai/code/session_01PYMuhnRSCirT5T3Bn4o4Lj
Planeshifter
commented
May 5, 2026
Planeshifter
commented
May 5, 2026
Planeshifter
commented
May 5, 2026
…es/dcorrelation` REPL help Per maintainer review: the explicit guard in the implementation is `N <= 0`, so the REPL help should match. https://claude.ai/code/session_01PYMuhnRSCirT5T3Bn4o4Lj
…se/gcartesian-power` Per maintainer review: "Creates" (third-person indicative) is the convention for these benchmark JSDoc summaries, not the imperative. https://claude.ai/code/session_01PYMuhnRSCirT5T3Bn4o4Lj
…n-power` benchmark JSDoc Aligns with the convention reaffirmed in maintainer review: third-person indicative, not imperative. https://claude.ai/code/session_01PYMuhnRSCirT5T3Bn4o4Lj
develop on 2026-05-04/05
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Follow-up fixes for commits merged to
developbetween 2026-05-04 14:00 PDT (a3a5677b7b) and 2026-05-05 03:03 PDT (c5fad82b2).This pull request:
73653a29dforlib/node_modules/@stdlib/stats/strided/distances/dcorrelation: aligns the README tagline, JS-API descriptions, removes an orphan<!-- </equation> -->tag, deduplicates a$ExpectErrorline indocs/types/test.tsthat masked a missing 5-arg negative case, and renames the include guard toSTDLIB_STATS_STRIDED_DISTANCES_DCORRELATION_Hto match the full package path.lib/node_modules/@stdlib/blas/ext/base/gcartesian-powerwith siblingdcartesian-power/scartesian-power(originating commit181b4cc56): switchesstrideOut1/strideOut2README descriptions from "stride length for" to "stride length of", and rewrites thecreateBenchmarkJSDoc summaries inbenchmark/benchmark.jsandbenchmark/benchmark.ndarray.jsRelated Issues
No.
Questions
No.
Other
Validation. Each finding was independently flagged by at least one reviewer agent and re-verified by re-reading the diff and the affected file. Compliance was checked against
docs/style-guidesand against established sibling packages (dcartesian-power/scartesian-powerfor the cartesian-power family,dscal/sscal/gscal/zscalfor the BLAS ndarray wrappers,deuclidean/dcosine-distance/dminkowskifor strided distances). Deliberately excluded: anything requiring interpretation, anything that could not be validated without touching code outside the diff window, and several false positives that did not survive verification (e.g., empty<intro>/<notes>README sections incscal— siblings have the same structure; an alleged missing scartesian-power benchmark "Creates" — the file already uses imperative).Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
This PR was prepared by Claude Code: the diff window was reviewed by four parallel agents (two style-guide compliance, two bug-hunting), every flagged issue was re-verified against the actual files in the worktree, false positives were filtered, and the surviving fixes were applied and grouped into per-package commits. Maintainer review of every change is expected before merge.
@stdlib-js/reviewers
Generated by Claude Code