feat: add ndarray/base/scalar-dtype (issue #11002)#11040
Open
Suhaniahirwar20 wants to merge 1 commit intostdlib-js:developfrom
Open
feat: add ndarray/base/scalar-dtype (issue #11002)#11040Suhaniahirwar20 wants to merge 1 commit intostdlib-js:developfrom
Suhaniahirwar20 wants to merge 1 commit intostdlib-js:developfrom
Conversation
stdlib-bot
added
First-time Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #11002.
Description
This pull request introduces a new utility
@stdlib/ndarray/base/scalar-dtypeto resolve a default ndarray data type from a scalar value.Previously, scalar-to-dtype resolution logic was duplicated across multiple packages such as:
ndarray/base/atleastndndarray/from-scalarThis PR extracts that logic into a reusable module, improving maintainability, consistency, and making it easier to extend support for additional data types in the future.
Changes include:
@stdlib/ndarray/base/scalar-dtypendarray/base/atleastndto use the new utilityRelated Issues
This pull request has the following related issues:
ndarray/base/scalar-dtype#11002Questions
No.
Other
No.
Checklist
AI Assistance
If you answered "yes" above, how did you use AI assistance?
Disclosure
I consulted ChatGPT to better understand the existing codebase and refactoring approach. The implementation and final changes were written and verified manually.
@stdlib-js/reviewers