Paper review#37
Merged
Merged
Conversation
Introduce graph::basic_edge<G,E> (source_id + target_id only) in the shared graph namespace, and redefine adj_list::edge to refine basic_edge plus the source/target vertex-descriptor CPOs. edge_list::basic_sourced_edgelist now requires basic_edge of its element type, tying both ADTs to one shared edge floor. Also drops the redundant target_id->source_id convertibility clause from basic_sourced_edgelist (return types are intentionally unconstrained, matching the adj_list side). Update edge_list interop test to assert the new basic_edge vs adj_list::edge contract.
Adds a uid overload to the vertex_value CPO that resolves to vertex_value(g, *find_vertex(g, uid)), matching the documented GCI default and mirroring the uid convenience overloads on out_edges/find_out_edge. Gated by a _has_uid constraint so it only participates when find_vertex(g, uid) is valid and vertex_value is available on the resulting vertex descriptor. Adds a test.
…rtex The uid overload now mirrors the descriptor dispatch: a member g.vertex_value(uid) or ADL vertex_value(g, uid) taking the id directly is preferred, and only when neither exists does it fall back to vertex_value(g, *find_vertex(g, uid)). Adds a _Choose_uid strategy and a test asserting id-taking member priority.
- Add basic_edge<G,E> (shared edge floor: source_id/target_id) and the refined adj_list edge<G,E> (+ source/target descriptors) to the concept reference, adjacency-list interface, and user guide. - Note that edge_list::basic_sourced_edgelist rests on the shared basic_edge, tying both ADTs together; update the edge-list interface hierarchy. - Document the vertex_value(g, uid) convenience overload and its member/ADL -> find_vertex dispatch in the CPO reference. - Add basic_edge nodes to the adjacency_list/edge_list concept .dot graphs and regenerate the .svg diagrams with graphviz.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.