[6.x] Forms 2: Field numbering#14909
Merged
Merged
Conversation
- the Builder and Logic components are now responsible for generating the field numbers, rather than the composable. - the FieldNumber component now injects the fieldNumbers and checks the "show" state itself. saving us from needing to pass it in. - the composable is now only responsible for the toggle state.
it does blink slightly when you toggle it because it has to remount the PublishContainer component. to avoid the blink, we'd need to swap PublishForm for using PublishContainer directly, then add slots in PublishFields and PublishField. it's not a major issue so going to keep it simple for now w/ the blink. if someone complains we can change it later.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request allows you to see numbers next to form fields in the Control Panel. Disabled by default, but can be toggled at the top of the Form Builder, Logic and Submission pages.
Originally part of #14811, but I split it out to make things easier to review.