Fix accidental mangling of model namespace name#1200
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1200 +/- ##
==========================================
- Coverage 91.10% 91.08% -0.02%
==========================================
Files 15 15
Lines 6125 6127 +2
==========================================
+ Hits 5580 5581 +1
- Misses 545 546 +1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Submission Checklist
Summary
Related to #1197, the model name argument is currently passed to
stancas a quoted string (i.e.,stanc --name='bernoulli_model'), causingstancto treat the quotes as part of the model name and escape/mangle them in the generated c++ (e.g.,x39bernoulli_modelx39_namespace).Additionally the pre-processing step for replacing spaces with underscores to generate the model name from filename is currently using the
sub()function instead ofgsub(), causing only the first space to be replaced (i.e.,name with spaces.stan->name_with spaces)Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Andrew Johnson
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: