Conversation
|
Ok I looked closer into how we're documenting things and actually using R6 documentation is a much bigger hurdle than I thought. Will not be trying to swap to R6 docs in this PR--don't know if there's a massive benefit to changing either. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #1185 +/- ##
=======================================
Coverage 91.21% 91.21%
=======================================
Files 15 15
Lines 6121 6121
=======================================
Hits 5583 5583
Misses 538 538 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
Yeah because of the severe limitations of R6 roxygen documentation when we first created cmdstanr, we had to come up with a different way of doing the doc. I had tried using the roxygen R6 support at the time and it just wasn't good enough to make useful documentation. I haven't looked too closely into the new R6 doc functionality in roxygen2 yet, but just because I knew it would be a pain to update. |
jgabry
left a comment
There was a problem hiding this comment.
Thanks, looks good, I just reran the one failing windows run.
Submission Checklist
Summary
Migrate to latest Roxygen2 version and did a quick redoc.
Copyright and Licensing
Please list the copyright holder for the work you are submitting
(this will be you or your assignee, such as a university or company):
Visruth Srimath Kandali
By submitting this pull request, the copyright holder is agreeing to
license the submitted work under the following licenses: