Add tests for theme/aesthetic helper functions#524
Open
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
Open
Add tests for theme/aesthetic helper functions#524utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
utkarshpawade wants to merge 2 commits intostan-dev:masterfrom
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Adds expanded test coverage for bayesplot theme/aesthetic convenience helpers, with checks for return types and compatibility when added to real bayesplot ggplot objects.
Changes:
- Added tests asserting helper outputs are incomplete themes and map
on = FALSEtoelement_blank(). - Added composition tests ensuring helpers and
overlay_function()can be added to real bayesplot plots. - Added a NEWS entry documenting the added tests.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| tests/testthat/test-convenience-functions.R | Adds new testthat cases around theme helper return types and plot composition. |
| NEWS.md | Documents newly added tests for theme/aesthetic helpers. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #524 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 35 35
Lines 5905 5905
=======================================
Hits 5827 5827
Misses 78 78 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #523
expect_s3_class, incomplete theme validation) forplot_bg(),panel_bg(),facet_bg(),legend_move(),legend_text()on = FALSE→element_blankverification for all three background helpersppc_hist,ppc_dens_overlay,ppc_dens)overlay_functionreturn type check (LayerInstance, nottheme) and plot compositionlegend_move("none")equivalence withlegend_none()