Merged
Conversation
- Mask the retrieved GitHub token with core.setSecret so it is redacted in logs - Stop logging the raw API response (contained the token) - Drop raw response body from error messages - Pass workflow_dispatch inputs via env vars instead of interpolating into shell - Pin all actions to SHA (via pinact) - Add least-privilege permissions blocks to workflows - Use yarn install --frozen-lockfile in CI - Set persist-credentials: false on read-only checkout - Bump action runtime from node16 (EOL) to node20
Member
|
Hi @MarshallOfSound, thanks for the PR! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A few defence-in-depth improvements, nothing here is actively being exploited but these close off some sharp edges.
Token handling (index.js)
core.setSecretso Actions masks it in logs before it's written as an outputconsole.log('API Response', data)call —dataincludes the tokenundefinedWorkflows
update-main-version.yml: passworkflow_dispatchinputs through env vars rather than interpolating directly intorun:(avoids shell expansion of thetargetinput)pinact)permissions:blocks (read by default, write only where a job pushes)yarn install --frozen-lockfilein CIpersist-credentials: falseon the lint checkoutRuntime
action.ymlfromnode16(EOL) tonode20Verified with
zizmor— 0 high findings remain. The two residual mediumartipackedwarnings are on checkouts that intentionally keep credentials to push back.