Skip to content

ROX-31937: Generate third-party deps license files.#192

Merged
ovalenti merged 5 commits intomainfrom
ovalenti/third_party_licenses
Feb 4, 2026
Merged

ROX-31937: Generate third-party deps license files.#192
ovalenti merged 5 commits intomainfrom
ovalenti/third_party_licenses

Conversation

@ovalenti
Copy link
Contributor

@ovalenti ovalenti commented Jan 20, 2026

Description

  • Provide an way to easily generate the third-party copyright+license bundle.
  • Add a CI check that the list of licenses used by dependencies is within the accepted list.

Checklist

  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

@ovalenti ovalenti self-assigned this Jan 20, 2026
@ovalenti ovalenti force-pushed the ovalenti/third_party_licenses branch 8 times, most recently from 8484fad to 153e7ac Compare January 22, 2026 10:57
@ovalenti ovalenti requested a review from Molter73 January 22, 2026 11:05
@ovalenti ovalenti marked this pull request as ready for review January 22, 2026 11:05
@ovalenti ovalenti requested a review from a team as a code owner January 22, 2026 11:05
@ovalenti
Copy link
Contributor Author

@Molter73 I think that the current state of this PR reflects what we discussed. Could you take a look ?

Copy link
Contributor

@Molter73 Molter73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM! Just a few comments.

branches:
- main
- release-*
- konflux/**
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we went back to using PRs for konflux/mintmaker updates, we can remove this one.

Suggested change
- konflux/**

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also make the check required? There is a mintmaker job for updating dependencies and I think this should be checked by it as well.

If so, you should look into adding the steps to https://github.com/stackrox/automation-iac/blob/main/resources/source-mgmt/repositories/fact.tf once this is merged to master.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we should make it 'required' before we have seen it run for a little bit.

Also, setting the flag on the job can be done only by admins.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am not sure that we should make it 'required' before we have seen it run for a little bit.

Fair.

Also, setting the flag on the job can be done only by admins.

You can open a PR to the repo I linked above and the automation team will take care of doing that for you, no need to be admin.

@ovalenti ovalenti force-pushed the ovalenti/third_party_licenses branch from 153e7ac to 5a8b7d5 Compare February 4, 2026 11:00
@ovalenti ovalenti force-pushed the ovalenti/third_party_licenses branch from 5a8b7d5 to c48d19b Compare February 4, 2026 14:24
@ovalenti ovalenti merged commit aed224b into main Feb 4, 2026
23 checks passed
@ovalenti ovalenti deleted the ovalenti/third_party_licenses branch February 4, 2026 15:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants