ROX-31937: Generate third-party deps license files.#192
Conversation
8484fad to
153e7ac
Compare
|
@Molter73 I think that the current state of this PR reflects what we discussed. Could you take a look ? |
Molter73
left a comment
There was a problem hiding this comment.
Mostly LGTM! Just a few comments.
.github/workflows/license-checks.yml
Outdated
| branches: | ||
| - main | ||
| - release-* | ||
| - konflux/** |
There was a problem hiding this comment.
Since we went back to using PRs for konflux/mintmaker updates, we can remove this one.
| - konflux/** |
There was a problem hiding this comment.
Should we also make the check required? There is a mintmaker job for updating dependencies and I think this should be checked by it as well.
If so, you should look into adding the steps to https://github.com/stackrox/automation-iac/blob/main/resources/source-mgmt/repositories/fact.tf once this is merged to master.
There was a problem hiding this comment.
I am not sure that we should make it 'required' before we have seen it run for a little bit.
Also, setting the flag on the job can be done only by admins.
There was a problem hiding this comment.
I am not sure that we should make it 'required' before we have seen it run for a little bit.
Fair.
Also, setting the flag on the job can be done only by admins.
You can open a PR to the repo I linked above and the automation team will take care of doing that for you, no need to be admin.
153e7ac to
5a8b7d5
Compare
PRs are sufficient now that we use those for auto-updates. Co-authored-by: Mauro Ezequiel Moltrasio <mmoltras@redhat.com>
5a8b7d5 to
c48d19b
Compare
Description
Checklist
Automated testing