Check reviewer markdown link integrity#49
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 97aefb6992
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| def _markdown_files() -> list[Path]: | ||
| return [ | ||
| REPO_ROOT / "README.md", | ||
| *sorted((REPO_ROOT / "docs").glob("*.md")), |
There was a problem hiding this comment.
Include nested docs in link check
The repo already contains Markdown files below nested docs/ directories, such as docs/reviewer-pack-v0.4.0/MANIFEST.md and docs/reviewer-pack-v0.6.0/MANIFEST.md, but this helper only collects top-level docs/*.md. Any local link added to those reviewer-pack manifests can break without this regression test failing, which leaves part of the documented reviewer surface outside the new integrity check; use a recursive docs scan if the test is meant to cover docs broadly.
Useful? React with 👍 / 👎.
|
Addressed the Codex review feedback in 7479bb8 by changing the Markdown link collector to scan nested docs and demo Markdown recursively. Local validation: |
Summary
Validation