Feature/upgrade to golangci lint v2

golang-ci.yaml

@@ -1,6 +1,3 @@
-# This file contains all available configuration options
-# with their default values.
-
 version: "2"
 # options for analysis running
 run:
@@ -10,6 +7,7 @@ run:
   # timeout for analysis, e.g. 30s, 5m, default is 1m
   timeout: 5m
 linters:
+  # https://golangci-lint.run/usage/linters/
   enable:
     - bodyclose
     - depguard
@@ -48,7 +46,6 @@ linters:
     gosec:
       excludes:
         # Suppressions: (see https://github.com/securego/gosec#available-rules for details)
-        - G101 # "Look for hardcoded credentials" -> a lot of false positives in descriptions for resources like mariadb/credential
         - G104 # "Audit errors not checked" -> which we don't need and is a badly implemented version of errcheck
         - G102 # "Bind to all interfaces" -> since this is normal in k8s
         - G304 # "File path provided as taint input" -> too many false positives
@@ -79,23 +76,18 @@ linters:
       checks:
         # default from https://golangci-lint.run/docs/linters/configuration/#staticcheck
         - all
-        - "-ST1000"
-        - "-ST1003"
-        - "-ST1016"
-        - "-ST1020"
-        - "-ST1021"
-        - "-ST1022"
+        - "-ST1000" # Incorrect or missing package comment.
+        - "-ST1003" # Poorly chosen identifier.
+        - "-ST1016" # Use consistent method receiver names.
+        - "-ST1020" # The documentation of an exported function should start with the function's name.
+        - "-ST1021" # The documentation of an exported type should start with type's name.
+        - "-ST1022" # The documentation of an exported variable or constant should start with variable's name.
         # customizations
         - "-SA1019" # disable deprecation errors while we switch over to the SDK structure with multi API version support
         - "-QF1001" # disable 'could apply De Morgan's law': readability of boolean expressions is subjective and should be decided on a case-by-case basis
         - "-QF1012" # disable 'use fmt.Fprintf instead' Fprintf returns bytes written and an error, which we'd have to handle/ignore to appease some other linter
   exclusions:
     generated: lax
-    rules:
-      - linters:
-          - gocritic
-        text: 'dupOption'
-        path: _acc_test\.go
     paths:
       - third_party$
       - builtin$

stackit/internal/services/access_token/ephemeral_resource_test.go

@@ -30,7 +30,7 @@ func startMockTokenServer() *httptest.Server {
 			Scope:       "mock_scope",
 		}
 		w.Header().Set("Content-Type", "application/json")
-		_ = json.NewEncoder(w).Encode(resp) // nolint:gosec // mock_access_token is not sensitive information
+		_ = json.NewEncoder(w).Encode(resp) //nolint:gosec // no secret, just a mock
 	})
 	return httptest.NewServer(handler)
 }

stackit/internal/services/cdn/distribution/resource.go

@@ -140,7 +140,7 @@ type backend struct {
 }
 
 type backendCredentials struct {
-	AccessKey *string `tfsdk:"access_key_id"`
+	AccessKey *string `tfsdk:"access_key_id"` //nolint:gosec // AccessKey should be exported from this struct
 	SecretKey *string `tfsdk:"secret_access_key"`
 }
 

stackit/internal/services/dns/dns_acc_test.go

@@ -117,12 +117,9 @@ func TestAccDnsMinResource(t *testing.T) {
 					resource.TestCheckResourceAttr("stackit_dns_zone.zone", "project_id", testutil.ProjectId),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "zone_id"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "state"),
-
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "primary_name_server"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "serial_number"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "state"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "visibility"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "zone_id"),
 					// Record set data
 					resource.TestCheckResourceAttrPair(
 						"stackit_dns_record_set.record_set", "project_id",
@@ -242,9 +239,7 @@ func TestAccDnsMinResource(t *testing.T) {
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "state"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "primary_name_server"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "serial_number"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "state"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "visibility"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "zone_id"),
 					// Record set data
 					resource.TestCheckResourceAttrPair(
 						"stackit_dns_record_set.record_set", "project_id",
@@ -306,9 +301,7 @@ func TestAccDnsMaxResource(t *testing.T) {
 					resource.TestCheckResourceAttr("stackit_dns_zone.zone", "type", testutil.ConvertConfigVariable(testConfigVarsMax["type"])),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "primary_name_server"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "serial_number"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "state"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "visibility"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "zone_id"),
 
 					resource.TestCheckResourceAttrSet("stackit_dns_record_set.record_set", "record_set_id"),
 					resource.TestCheckResourceAttr("stackit_dns_record_set.record_set", "name", testutil.ConvertConfigVariable(testConfigVarsMax["record_name"])),
@@ -480,9 +473,7 @@ func TestAccDnsMaxResource(t *testing.T) {
 					resource.TestCheckResourceAttr("stackit_dns_zone.zone", "type", testutil.ConvertConfigVariable(testConfigVarsMax["type"])),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "primary_name_server"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "serial_number"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "state"),
 					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "visibility"),
-					resource.TestCheckResourceAttrSet("stackit_dns_zone.zone", "zone_id"),
 					// Record set data
 					resource.TestCheckResourceAttrPair(
 						"stackit_dns_record_set.record_set", "project_id",