Skip to content

Support control_plane attribute in ske cluster#1236

Merged
Fyusel merged 15 commits intomainfrom
feat/support-control-plane-for-ske-cluster
Mar 12, 2026
Merged

Support control_plane attribute in ske cluster#1236
Fyusel merged 15 commits intomainfrom
feat/support-control-plane-for-ske-cluster

Conversation

@GokceGK
Copy link
Contributor

@GokceGK GokceGK commented Feb 17, 2026

Description

relates to STACKITTPR-517

Checklist

  • Issue was linked above
  • Code format was applied: make fmt
  • Examples were added / adjusted (see examples/ directory)
  • Docs are up-to-date: make generate-docs (will be checked by CI)
  • Unit tests got implemented or updated
  • Acceptance tests got implemented or updated (see e.g. here)
  • Unit tests are passing: make test (will be checked by CI)
  • No linter issues: make lint (will be checked by CI)

@GokceGK GokceGK requested a review from a team as a code owner February 17, 2026 16:24
@GokceGK GokceGK marked this pull request as draft February 24, 2026 15:02
@github-actions
Copy link

github-actions bot commented Mar 4, 2026

This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it.

@github-actions github-actions bot added the Stale PR is marked as stale due to inactivity. label Mar 4, 2026
@github-actions github-actions bot removed the Stale PR is marked as stale due to inactivity. label Mar 10, 2026
@GokceGK GokceGK marked this pull request as ready for review March 10, 2026 17:16
@github-actions
Copy link

Merging this branch will increase overall coverage

Impacted Packages Coverage Δ 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske 0.00% (ø)
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster 50.00% (+0.72%) 👍

Coverage by file

Changed files (no unit tests)

Changed File Coverage Δ Total Covered Missed 🤖
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/datasource.go 0.00% (ø) 39 0 39
github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource.go 52.21% (+0.71%) 881 (+17) 460 (+15) 421 (+2) 👍

Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code.

Changed unit test files

  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/cluster/resource_test.go
  • github.com/stackitcloud/terraform-provider-stackit/stackit/internal/services/ske/ske_acc_test.go

@Fyusel Fyusel merged commit 146a310 into main Mar 12, 2026
3 checks passed
@Fyusel Fyusel deleted the feat/support-control-plane-for-ske-cluster branch March 12, 2026 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants