Conversation
ske-prow
bot
added
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ske-prow
bot
added
the
size/L
jamand
force-pushed
the
feat/add-machine-internal-ip-status-field
branch
from
0a4a0d5 to
2e0be67
Compare
| } | ||
|
|
||
| if err := p.patchNetworkInterface(ctx, projectID, server.ID, providerSpec); err != nil { | ||
| nics, err := p.client.GetNICsForServer(ctx, projectID, providerSpec.Region, server.ID) |
There was a problem hiding this comment.
In order to keep the main create function as clean as possible, i think its best to keep the GetNICs function in the patchNetworkInterface function but have it return the patched interfaces.
the UpdateNic Function also returns the updated NIC, which we currently just throw away. Just use these, put them in a list and return them :)
And maybe also rename patchNetworkInterface to patchNetworkInterfaces while doing so :D
2 participants
How to categorize this PR?
/kind enhancement
What this PR does / why we need it:
Similar to gardener/machine-controller-manager-provider-openstack#322
Server InternalIPs are now returned on created Machines, so that they may be used for access. This is needed, as the provided hostname field already written into is the
MachineStatus.Addressesis not resolvable on STACKIT.Which issue(s) this PR fixes:
x
Special notes for your reviewer:
The
clientSuite was previously not registered and there was a small bug in one test case./hold Running tests first