Conversation
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
|
/hold until tested |
|
/unhold |
nschad
left a comment
There was a problem hiding this comment.
I feel like everywhere we use ptr.To instead of Go 1.26 new. Should we really change that? We also use ptr.Deref in some cases
Personally new is also kinda confusing to me, new what? 🤷
Is that new recommendation coming from the golangci-lint modernize plugin?
Everything changed were just recommendations by modernize and even though |

How to categorize this PR?
/kind technical-debt
What this PR does / why we need it:
Updates to go 1.26.1 with its latest language features
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Breaking changes: