Skip to content

stackit ccm use new stackit client#1201

Merged
ske-prow[bot] merged 7 commits into
mainfrom
cleanup-stackit-client-1
Jun 19, 2026
Merged

stackit ccm use new stackit client#1201
ske-prow[bot] merged 7 commits into
mainfrom
cleanup-stackit-client-1

Conversation

@aniruddha2000

@aniruddha2000 aniruddha2000 commented Jun 10, 2026

Copy link
Copy Markdown
Member

How to categorize this PR?

/kind enhancement

What this PR does / why we need it:

This PR is a part of breaking down #1060 PR into smaller pieces, where we are having ccm using new stackit client.

Which issue(s) this PR fixes:
Fixes #

Special notes for your reviewer:

IaaS functions being added

GetServer
ListServers

LoadBalancer functions being added

CreateLoadBalancer
GetLoadBalancer
UpdateLoadBalancer
DeleteLoadBalancer
UpdateTargetPool

CreateCredentials
ListCredentials
UpdateCredentials
DeleteCredentials

In-terms of client code, there is no major changes, just it follows new way of using the stackit client.

NOTE:

In respective of testing the ccm uses the new client and the unit tests are being changed but we need to test it on ondemand.

Breaking changes:

@ske-prow ske-prow Bot added kind/enhancement Enhancement, improvement, extension size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Jun 10, 2026
@aniruddha2000

aniruddha2000 commented Jun 11, 2026

Copy link
Copy Markdown
Member Author

/test pull-cloud-provider-stackit-verify

breuerfelix
breuerfelix requested changes Jun 15, 2026
View reviewed changes
Comment thread pkg/stackit/client/iaas.go Outdated
Comment thread pkg/stackit/client/loadbalancer.go Outdated
Comment thread pkg/stackit/client/loadbalancer.go Outdated
Comment thread pkg/stackit/client/factory.go Outdated
Comment thread pkg/ccm/instances.go Outdated
Comment thread pkg/ccm/loadbalancer.go Outdated
@breuerfelix

breuerfelix commented Jun 16, 2026

Copy link
Copy Markdown
Member

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

@stackit-ske

stackit-ske commented Jun 16, 2026

Copy link
Copy Markdown

@breuerfelix: once the present PR merges, I will cherry-pick it on top of release-v1.33, release-v1.34, release-v1.35, release-v1.36 in new PRs and assign them to you.

Details

In response to this:

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@breuerfelix breuerfelix force-pushed the cleanup-stackit-client-1 branch from 34463e5 to 765a187 Compare June 16, 2026 15:00
nschad
nschad reviewed Jun 17, 2026
View reviewed changes
Comment thread pkg/stackit/client/loadbalancer.go
Comment thread pkg/stackit/client/loadbalancer.go
@nschad

nschad commented Jun 19, 2026

Copy link
Copy Markdown
Contributor

/lgtm

@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@ske-prow

ske-prow Bot commented Jun 19, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 51fb33a403dade44bb958ab5ce4260f26bfcc75a

aniruddha2000 and others added 7 commits June 19, 2026 09:52
@aniruddha2000 @breuerfelix
CCM directory use now new stackit client
b33f6cd
@aniruddha2000 @breuerfelix
make fmt
b395df0
@aniruddha2000 @breuerfelix
remove unused projectID and add uuid in object creation in client
ea3d130
@breuerfelix
add wrapper for the stackit ID header
72d90a4 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix
fix make verify
120bf84 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix
rename helper file
8eced72 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix
remove more readonly fields
663f521 
Signed-off-by: Felix Breuer <f.breuer94@gmail.com>
@breuerfelix breuerfelix force-pushed the cleanup-stackit-client-1 branch from 765a187 to 663f521 Compare June 19, 2026 07:52
@ske-prow ske-prow Bot removed the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@ske-prow ske-prow Bot added the lgtm Indicates that a PR is ready to be merged. label Jun 19, 2026
@ske-prow

ske-prow Bot commented Jun 19, 2026

Copy link
Copy Markdown

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: breuerfelix

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ske-prow

ske-prow Bot commented Jun 19, 2026

Copy link
Copy Markdown

LGTM label has been added.

DetailsGit tree hash: 273dfe485fcdefc847a4dc4401e7b909e784b984

@ske-prow ske-prow Bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 19, 2026
@ske-prow ske-prow Bot merged commit ee81df6 into main Jun 19, 2026
3 checks passed
@ske-prow ske-prow Bot deleted the cleanup-stackit-client-1 branch June 19, 2026 11:28
@stackit-ske

stackit-ske commented Jun 19, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1240

Details

In response to this:

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jun 19, 2026
Merged
@stackit-ske

stackit-ske commented Jun 19, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1241

Details

In response to this:

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jun 19, 2026
Merged
@stackit-ske

stackit-ske commented Jun 19, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1242

Details

In response to this:

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jun 19, 2026
Merged
@stackit-ske

stackit-ske commented Jun 19, 2026

Copy link
Copy Markdown

@breuerfelix: new pull request created: #1243

Details

In response to this:

/cherrypick release-v1.33
/cherrypick release-v1.34
/cherrypick release-v1.35
/cherrypick release-v1.36

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@stackit-ske stackit-ske mentioned this pull request Jun 19, 2026
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xoxys xoxys xoxys left review comments

@nschad nschad nschad left review comments

@breuerfelix breuerfelix breuerfelix approved these changes

Assignees

No one assigned

Labels

approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@aniruddha2000 @breuerfelix @stackit-ske @nschad @xoxys