Add compatibility for NIC names with dashes#2370
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the secret_store_bind_interface variable in vault-bao-migration-overcloud.yml to replace hyphens with underscores. The reviewer noted that this same variable is defined later in the file (on line 42) for an imported playbook, and recommended applying the same filter there to prevent the second play from failing.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
When Ansible gathers facts, it silently converts dashes in network interface names into underscores, resulting precheck failure on Vault to OpenBao migration for overcloud. Fixed with adding ``replace()`` filter when getting ``secret_store_bind_interface``.
seunghun1ee
force-pushed
the
vault-bao-nic-name-fix
branch
from
0ae2a53 to
528c1b1
Compare
|
Tested on multinode with custom interface names with dashes |
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
Sorry to scope-creep this a bit, but should we also do the same for other secret-store/* playbooks?
|
Not really. The equivalent variable only appears in secret-store-deploy-overcloud.yml. But the way it gets the ip address from the chosen network interface is different. The deployment playbook uses net_ip filter whereas the migration playbook uses attributes from ansible_facts. I can't remember the background of this difference. Maybe because net_ip filter is known that it can fail and we wanted to move away from it? |
These vars are only used for stackhpc.hashicorp.vault_bao_migration playbook and not needed for the previous tasks.
3 participants
When Ansible gathers facts, it silently converts dashes in network interface names into underscores, resulting precheck failure on Vault to OpenBao migration for overcloud.
Fixed with adding
replace()filter when gettingsecret_store_bind_interface.