Skip to content

Implement multinode testing for Rocky 10#2367

Draft
owenjones wants to merge 1 commit into
stackhpc/2025.1from
rl10/multinode
Draft

Implement multinode testing for Rocky 10#2367
owenjones wants to merge 1 commit into
stackhpc/2025.1from
rl10/multinode

Conversation

@owenjones

@owenjones owenjones commented Jun 12, 2026

Copy link
Copy Markdown
Member

@github-actions github-actions Bot added the waiting-review PR is waiting for a review label Jun 12, 2026

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for Rocky 10 and CentOS Stream 10 by updating repository versions, conditionally enabling Redis or Valkey depending on the OS version, and updating the stackhpc.cephadm collection. It also adds a temporary workaround to set the crypto policy to LEGACY on Rocky 10 during Ceph deployment due to SHA-1 signing keys. Feedback on the changes highlights potential issues in cephadm-deploy.yml where rhel10cis_crypto_policy might be undefined, and suggests wrapping the role execution in a block/always structure to guarantee the crypto policy is restored even if the deployment fails.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread etc/kayobe/ansible/ceph/cephadm-deploy.yml Outdated
@owenjones owenjones force-pushed the rl10/multinode branch 2 times, most recently from 9a82c62 to e840255 Compare June 12, 2026 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

waiting-review PR is waiting for a review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant