Split out ci-aio and aio environments#2353
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request splits the all-in-one (AIO) environment configuration into a base aio environment and a derived ci-aio environment containing only CI-specific overrides. It also updates the documentation and automated setup scripts to reflect this structure. However, several critical issues were identified in the review: trailing spaces in the lookup filenames in release-train.yml will cause file-not-found errors, a critical bug in automated-setup.sh incorrectly sets KAYOBE_VAULT_PASSWORD to the Pulp username, and a documentation link in ci-aio.rst incorrectly points back to itself instead of the new aio documentation.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Alex-Welsh
force-pushed
the
split-aio
branch
2 times, most recently
from
5fd1dec to
c498f33
Compare
Alex-Welsh
force-pushed
the
split-aio
branch
2 times, most recently
from
256a378 to
7d5ceaa
Compare
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request splits the ci-aio Kayobe environment into two distinct environments: aio for manual deployments and ci-aio for CI testing, which inherits from aio. This refactoring simplifies manual setups and cleans up CI-specific overrides. The review feedback highlights two issues: first, the Ansible file lookup plugin in release-train.yml does not automatically perform tilde expansion, which could cause credential lookups to fail; second, the Pulp credential check in automated-setup.sh only flags 401 errors, potentially ignoring other HTTP failures instead of verifying a successful 200 response.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
This change splits the ci-aio environment into two envs. "aio" is a new environment, designed to be deployed manually. "ci-aio" now inherits from the "aio" env and overrides some variables with CI-specific changes. This allows cleaner separation between what is "aio" and what is "ci". It makes it much easier for customers to now deploy their own AIO instancs.
1 participant
This change splits the ci-aio environment into two envs. "aio" is a new environment, designed to be deployed manually. "ci-aio" now inherits from the "aio" env and overrides some variables with CI-specific changes.
This allows cleaner separation between what is "aio" and what is "ci". It makes it much easier for customers to now deploy their own AIO instances.