Fix manifest push failure handling (Caracal)#2195
Merged
bbezak merged 1 commit intostackhpc/2024.1from Mar 4, 2026
Merged
Conversation
Signed-off-by: Bartosz Bezak <bartosz@stackhpc.com> (cherry picked from commit e22310d)
seunghun1ee
added
Caracal
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request significantly improves the robustness of the multi-architecture manifest creation script by correctly handling errors within pipelines. The introduction of "set -o pipefail" ensures that failures from "docker manifest create" or "docker manifest push" are no longer masked when output is piped to "tee", which is a critical fix for CI stability. Additionally, the image filtering logic has been refactored for better conciseness and efficiency.
bbezak
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(cherry picked from commit e22310d)