Merged
Conversation
Trivy had security incident on 1st March 2026 [1], resulting losing all GitHub Releases between 0.27.0-0.69.1. They then restored the latest as 0.69.2 [1] aquasecurity/trivy#10265 (cherry picked from commit 9144c9f)
priteau
approved these changes
Mar 2, 2026
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the recommended Trivy version in the scan-images.sh script to v0.69.2. The change is correct and aligns with the reasons outlined in the description. I have provided one suggestion to improve the robustness of the script by enhancing the check for Trivy's installation. This will provide a better user experience by failing early with a clear error message if Trivy is not available.
Comment on lines
13
to
15
| if ! trivy --version; then | ||
| echo 'Please install trivy: curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.49.1' | ||
| echo 'Please install trivy: curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.69.2' | ||
| fi |
Contributor
There was a problem hiding this comment.
The current check for trivy can be improved for robustness and better user experience.
- If
trivyis installed,trivy --versionprints its output to stdout, which can be noisy. - If
trivyis not installed, the script prints a message but continues, failing later on. This can be confusing for the user. - Diagnostic messages should be printed to stderr, not stdout.
The suggested change addresses these points by silencing the version check, exiting immediately if trivy is not found, and printing messages to stderr.
Suggested change
| if ! trivy --version; then | |
| echo 'Please install trivy: curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.49.1' | |
| echo 'Please install trivy: curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.69.2' | |
| fi | |
| if ! trivy --version >/dev/null 2>&1; then | |
| echo "Error: trivy not found. Please install v0.69.2:" >&2 | |
| echo 'curl -sfL https://raw.githubusercontent.com/aquasecurity/trivy/main/contrib/install.sh | sh -s -- -b /usr/local/bin v0.69.2' >&2 | |
| exit 1 | |
| fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trivy had security incident on 1st March 2026 [1], resulting losing all GitHub Releases between 0.27.0-0.69.1.
They then restored the latest as 0.69.2
[1] aquasecurity/trivy#10265
(cherry picked from commit 9144c9f)