Conversation
owenjones
commented
Feb 26, 2026
- some of the RL9 repositories might also be required in RL10 (is there a list of what we want in each image somewhere?), so will possibly need to come back and fix the required flag on those to include them
- it feels like there's scope for templating this a bit better as there's a lot of duplication between RL9 and RL10 entries, but that will need a bit of planning
There was a problem hiding this comment.
Code Review
This pull request adds support for Rocky 10 repositories by defining new variables and configurations across several YAML files. The changes are extensive and largely mirror the existing setup for Rocky 9. While the approach is sound, I've identified a few critical copy-paste errors in repository URLs that would likely cause failures. I've also included a suggestion for improving naming consistency. Your observation in the PR description about the potential for templating to reduce duplication is a good one and should be considered for future refactoring.
b817ea2 to
293abe8
Compare
Alex-Welsh
left a comment
There was a problem hiding this comment.
This is a good start.
When I added the repos to release train, I included repos for both Epoxy and Gazpacho, which seems to have caused some confusion. I apologise, I should've split those changes out into two PRs.
I think you need a combination of this file and the
There certainly is. My concern would be there's enough that doesn't overlap that de-duplication of some parts and not others would just add complexity overall. In this case, let's keep going as we have before, but we should think about this for the next release. It would require a bit of planning as you say, and we're a bit late for that this time. |
etc/kayobe/pulp-repo-versions.yml
Outdated
| stackhpc_pulp_repo_doca_3_2_1_rhel10_aarch64_version: 20260220T152827 | ||
| stackhpc_pulp_repo_doca_3_2_1_rhel10_x86_64_version: 20260220T152827 |
There was a problem hiding this comment.
Does this work? given that it doesn't match the other DOCA var name formats it looks... suspicious
There was a problem hiding this comment.
Ah I used it from the short name in release train - will it need fixing there to be able to update correct package version here?
Added Rocky Linux 10 repositories for 2025.1 release