Support Kolla image tags overrides per environment#2176
Support Kolla image tags overrides per environment#2176grzegorzkoper wants to merge 5 commits intostackhpc/2025.1from
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces support for overriding Kolla image tags per environment, enhancing flexibility in deployment configurations. The changes involve updating documentation in etc/kayobe/kolla/globals.yml and tools/kolla-images.py to reflect this new capability. The Python script tools/kolla-images.py has been refactored to include new functions for reading, merging, and loading image tags from both a base file and an optional environment-specific override file. This refactoring improves modularity and robustness, with appropriate error handling for missing or invalid tag configurations. The overall change is a positive step towards more dynamic and environment-aware image tag management.
Alex-Welsh
left a comment
There was a problem hiding this comment.
I'll do a full review some other time, but I just want to mention:
- This is a really nice feature
- The Python component of SKC is starting to grow. I think that's a good thing. Ansible is great for some tasks but can become a complete mess when you try to do anything complicated. But we should think about python unit tests & linting
- needs a reno
|
No description provided.