Skip to content

Support Kolla image tags overrides per environment#2176

Open
grzegorzkoper wants to merge 5 commits intostackhpc/2025.1from
multi-env-kolla-images
Open

Support Kolla image tags overrides per environment#2176
grzegorzkoper wants to merge 5 commits intostackhpc/2025.1from
multi-env-kolla-images

Conversation

@grzegorzkoper
Copy link
Contributor

No description provided.

@grzegorzkoper grzegorzkoper requested a review from a team as a code owner February 24, 2026 23:27
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces support for overriding Kolla image tags per environment, enhancing flexibility in deployment configurations. The changes involve updating documentation in etc/kayobe/kolla/globals.yml and tools/kolla-images.py to reflect this new capability. The Python script tools/kolla-images.py has been refactored to include new functions for reading, merging, and loading image tags from both a base file and an optional environment-specific override file. This refactoring improves modularity and robustness, with appropriate error handling for missing or invalid tag configurations. The overall change is a positive step towards more dynamic and environment-aware image tag management.

Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll do a full review some other time, but I just want to mention:

  1. This is a really nice feature
  2. The Python component of SKC is starting to grow. I think that's a good thing. Ansible is great for some tasks but can become a complete mess when you try to do anything complicated. But we should think about python unit tests & linting
  3. needs a reno

@grzegorzkoper
Copy link
Contributor Author

I'll do a full review some other time, but I just want to mention:

  1. This is a really nice feature
  2. The Python component of SKC is starting to grow. I think that's a good thing. Ansible is great for some tasks but can become a complete mess when you try to do anything complicated. But we should think about python unit tests & linting
  3. needs a reno
  1. Thanks
  2. Good point, something that K/A and Kayobe already are doing - worth checking there for inspiration ?
  3. Done

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants