Skip to content

Add connect_without_watcher function#59

Draft
jgould22 wants to merge 3 commits intostackabletech:mainfrom
jgould22:feature/add_connect_without_watcher
Draft

Add connect_without_watcher function#59
jgould22 wants to merge 3 commits intostackabletech:mainfrom
jgould22:feature/add_connect_without_watcher

Conversation

@jgould22
Copy link

@jgould22 jgould22 commented Feb 24, 2026

This PR addresses #58

While debugging what I initially thought was a watcher compatibility issue with clickhouse-keeper which exposes a zookeeper compatible api (with some exceptions, see here ) would fail to connect with Error { source: None, message: "failed to enqueue new request: Canceled" }

Still need to poke it it a bit though because I thought I had it working but it still isnt.

Regardless.

This PR adds the connect_without_watcher method which allows a connection without the watcher stream.

Additionally it adds some convenience code to allow developers to set the address for the test zookeeper instance and updates the README.md to mention this.

@stackable-cla
Copy link

stackable-cla bot commented Feb 24, 2026

CLA assistant check
All committers have signed the CLA.

@jgould22 jgould22 marked this pull request as draft February 24, 2026 21:32
@jgould22 jgould22 force-pushed the feature/add_connect_without_watcher branch from cb9e121 to 9e32b63 Compare February 24, 2026 21:44
@jgould22
Copy link
Author

CLA assistant check Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.You have signed the CLA already but the status is still pending? Let us recheck it.

I am getting Unknown authentication strategy "github" however that is the only one offered

Error: Unknown authentication strategy "github"
    at attempt (/cla-assistant/node_modules/passport/lib/middleware/authenticate.js:190:39)
    at authenticate (/cla-assistant/node_modules/passport/lib/middleware/authenticate.js:367:7)
    at checkReturnTo (/cla-assistant/src/server/src/controller/user.js:39:7)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at next (/cla-assistant/node_modules/express/lib/router/route.js:137:13)
    at Route.dispatch (/cla-assistant/node_modules/express/lib/router/route.js:112:3)
    at Layer.handle [as handle_request] (/cla-assistant/node_modules/express/lib/router/layer.js:95:5)
    at /cla-assistant/node_modules/express/lib/router/index.js:281:22
    at Function.process_params (/cla-assistant/node_modules/express/lib/router/index.js:335:12)
    at next (/cla-assistant/node_modules/express/lib/router/index.js:275:10)

@lfrancke
Copy link
Member

Sorry, we'll look into the CLA bot

@Jimvin
Copy link
Member

Jimvin commented Feb 26, 2026

@jgould22 Could you try signing the CLA again please? It should be working now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants