Add connect_without_watcher function#59
Draft
jgould22 wants to merge 3 commits intostackabletech:mainfrom
Draft
Conversation
…configuration of the test zookeeper instance
cb9e121 to
9e32b63
Compare
Author
I am getting Unknown authentication strategy "github" however that is the only one offered |
Member
|
Sorry, we'll look into the CLA bot |
Member
|
@jgould22 Could you try signing the CLA again please? It should be working now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses #58
While debugging what I initially thought was a watcher compatibility issue with clickhouse-keeper which exposes a zookeeper compatible api (with some exceptions, see here ) would fail to connect with
Error { source: None, message: "failed to enqueue new request: Canceled" }Still need to poke it it a bit though because I thought I had it working but it still isnt.
Regardless.
This PR adds the
connect_without_watchermethod which allows a connection without the watcher stream.Additionally it adds some convenience code to allow developers to set the address for the test zookeeper instance and updates the README.md to mention this.