feat(hadoop): Add 3.5.0 and 3.4.3#1511
Conversation
| @@ -0,0 +1,2 @@ | |||
| # FIXME: Use released commit | |||
There was a problem hiding this comment.
Could we use patchable instead and avoid uploading sources to Nexus?
There was a problem hiding this comment.
As in, it becomes an image layer with a boil-config.toml and patches
There was a problem hiding this comment.
It looks like you did, since there is "shared/boost". We just need to mirror the repo (if not done).
There was a problem hiding this comment.
I copied the Dockerfile from @razvan and he documented it here:
docker-images/shared/boost/Dockerfile
Lines 10 to 14 in 61741f6
There was a problem hiding this comment.
I think Druid should be its own PR
There was a problem hiding this comment.
I see all the other products were update in this PR too.
I guess it is fine, but maybe find the tracking issues to link this PR in them (did you do the whole task for all, or only hdfs related stuff?)
There was a problem hiding this comment.
The reminder only have TODOs. How was druid different (why could it have the bump while the others couldn't)?
There was a problem hiding this comment.
I kept the ones where the compilation worked. All the ones where I was running into compilation errors which I couldn't solve in a sane timeframe I left as a TODO.
Such big changes in a patch level release suck... Any maven dependency resolution sucks, argh
NickLarsenNZ
left a comment
There was a problem hiding this comment.
Looks fine. I didn't check in detail, but that should come out via testing.
I left a few comments for clarifications.
Description
Part of #1494
Needs stackabletech/hdfs-utils#62
/stackable/hadoop-cloud-libraries/, so that dependant images can easily pull them in. Side node: We now support 3 different Hadoop versions with 3 different naming conventions, argh.Definition of Done Checklist
Note
Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant.
Please make sure all these things are done and tick the boxes
TIP: Running integration tests with a new product image
The image can be built and uploaded to the kind cluster with the following commands:
See the output of
boilto retrieve the image manifest URI for<MANIFEST_URI>.