Improve safety, dependencies, and developer setup#36
Merged
Conversation
Swift client: validate WebSocket URL, avoid unowned captures in the monitoring interval, and surface JSON serialization failures in DEBUG. WebSocket relay: upgrade to ws v8, drop the erroneous yarn dependency, and forward messages only to other connected clients. Browser: upgrade webpack 5 and jQuery/jqTree, fix broken npm scripts, and reduce npm audit findings from 145 to 2 (dev-only). README and Makefile document the correct install and start flow.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Improvements from a repo review: Swift client robustness, WebSocket relay cleanup, Browser toolchain upgrades, and clearer setup docs.
Changes
Swift (
RIBsTreeViewerClient)webSocketURLinstead of force-unwrappingURL(string:)[weak self]in the monitoring interval (avoids retain/crash risk fromunowned)WebSocketClientDelegatetoAnyObjectWebSocket relay (
WebSocketServer)wsto v8 and remove mistakenyarnnpm dependencynpm startscript andPORTenv supportBrowser viewer
startscript[JSON.parse(e.data)]Docs / DX
websocket-serverandbrowser-buildtargetsFollow-ups (not in this PR)