Add MessageExpressionAuthorizationManager#18813
Conversation
jzheaux
left a comment
There was a problem hiding this comment.
Hi, @wonderfulrosemari! Thanks for this PR. I've left some feedback inline.
...ingframework/security/messaging/access/expression/MessageExpressionAuthorizationManager.java
Outdated
Show resolved
Hide resolved
...ingframework/security/messaging/access/expression/MessageExpressionAuthorizationManager.java
Outdated
Show resolved
Hide resolved
|
Thanks for the feedback. I removed the deprecated setter and replaced the public (expressionHandler, expression) constructor with a builder-style API using withSecurityExpressionHandler(...).expression(...), and updated the WebSocket XML parser and tests accordingly. |
|
Thanks for the updates, @wonderfulrosemari. In preparation for merging, will you please squash your commits and change the title of your new commit to "Add MessageExpressionAuthorizationManager"? |
2dd8978 to
e23822e
Compare
|
Thanks, @wonderfulrosemari! Sorry for a miscommunication, it is still helpful to have the This helps with future research when trying to track down why a specific change to the codebase was made. Will you please change your commit message to include the above? |
Closes spring-projectsgh-12650 Signed-off-by: wonderfulrosemari <whwlsgur1419@naver.com>
e23822e to
56ab9da
Compare
|
Updated the commit message to include "Closes gh-12650". Thanks! |
Closes gh-12650
This PR promotes expression-based message authorization to a public API by
introducing
MessageExpressionAuthorizationManagerin the messaging module.Changes include:
MessageExpressionAuthorizationManagerand unit teststhe private inner class