Clarify Session Management Persistence Documentation#18345
Open
sankranty wants to merge 2 commits intospring-projects:6.5.xfrom
Open
Clarify Session Management Persistence Documentation#18345sankranty wants to merge 2 commits intospring-projects:6.5.xfrom
sankranty wants to merge 2 commits intospring-projects:6.5.xfrom
Conversation
spring-projects-issues
added
the
status: waiting-for-triage
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
jzheaux
requested changes
Jan 14, 2026
Contributor
jzheaux
left a comment
jzheaux
left a comment
There was a problem hiding this comment.
Hi, @sankranty, thanks for the PR. I agree that this could be clearer. I've left my suggestions inline.
docs/modules/ROOT/pages/servlet/authentication/session-management.adoc
Outdated
Show resolved
Hide resolved
jzheaux
added
in: docs
jzheaux
added
the
status: waiting-for-feedback
jzheaux
removed
the
status: waiting-for-feedback
jzheaux
added
the
status: waiting-for-feedback
Corrected that starting from Spring Security 6 security context is not automatically saved by default. Signed-off-by: sankranti <sankranti@ya.ru>
Signed-off-by: Josh Cummings <3627351+jzheaux@users.noreply.github.com>
jzheaux
force-pushed
the
session-docs-correction
branch
from
c836ffb to
f18004e
Compare
jzheaux
changed the title
Contributor
|
@sankranty, I polished some of the wording to clarify how sessions are persisted in modern Spring Security versions. In order to merge your contribution, your DCO signature needs to be corrected. Please note how the email address in your commit header is different from the email address in your DCO signature. Can you take a look at that please and update that commit? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Corrected that starting from Spring Security 6 security context is not automatically saved by default.