UriModifyingContentModifier.modifyContent decodes with the request charset but re-encodes with the platform default#1041
Closed
config25 wants to merge 0 commit intospring-projects:3.0.xfrom
Conversation
wilkinsona
requested changes
Apr 13, 2026
Member
wilkinsona
left a comment
wilkinsona
left a comment
There was a problem hiding this comment.
Please run ./gradlew format and update the proposal with the resulting changes.
wilkinsona
changed the title
wilkinsona
added
type: bug
config25
force-pushed
the
fix/uri-modifier-charset-encoding
branch
from
a8bf53f to
e7f0e1c
Compare
Contributor
Author
|
Sorry about that. I've run |
wilkinsona
force-pushed
the
fix/uri-modifier-charset-encoding
branch
from
e7f0e1c to
4a55491
Compare
Member
|
Re-opening as I botched up the processing. |
Member
|
@config25 Sorry, I botched up the processing of this PR and it looks like GitHub won't let me re-open it. Can you please re-open it so that I can tidy things up? |
Contributor
Author
|
@wilkinsona Reopened the work as #1043 since GitHub wouldn't let me reopen this one. Same branch, same commit (e7f0e1c) — should be ready for you to tidy up. |
Member
|
Thanks very much. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UriModifyingContentModifier.modifyContent()decodes the request/responsebody using the charset from the Content-Type header, but re-encodes with
String.getBytes()(no charset argument), which falls back to the JVMdefault. When these differ, non-ASCII characters get corrupted.
Use the same charset for both decoding and encoding, falling back to
Charset.defaultCharset()when no charset is declared.Fixes gh-1039