Augment FieldError.java's javadoc#36559
Open
ottlinger wants to merge 1 commit intospring-projects:mainfrom
Open
Augment FieldError.java's javadoc#36559ottlinger wants to merge 1 commit intospring-projects:mainfrom
ottlinger wants to merge 1 commit intospring-projects:mainfrom
Conversation
to make clearer that defaultMessage is not a i18n key from your application bundle, but a static string. Resulting in a problem that setting defaultMessage means no i18n. If you want i18n you should use the code parameter. Behaviour shown in: * https://github.com/ottlinger/custom-validation-messages-1029 * reported and resolved via thymeleaf/thymeleaf#1029 Signed-off-by: P. Ottlinger <ottlinger@users.noreply.github.com>
spring-projects-issues
added
the
status: waiting-for-triage
Contributor
DhruvTheDev1
left a comment
DhruvTheDev1
left a comment
There was a problem hiding this comment.
Simple but effective change. By adding 'static' to the defaultMessage description it helps to prevent from accidentally passing translation keys into the wrong parameter.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to make clearer that defaultMessage is not a i18n key from your application bundle, but a static string. Resulting in a problem that setting defaultMessage means no i18n. If you want i18n you should use the code parameter.
Behaviour shown in: