Skip to content

Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - Prevent concurrent channelCache access during shutdown and refresh#3201

Open
dileepharithasa wants to merge 2 commits into
spring-cloud:mainfrom
dileepharithasa:fix/Unsafe-StreamBridge-Cache-Implementation
Open

Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - Prevent concurrent channelCache access during shutdown and refresh#3201
dileepharithasa wants to merge 2 commits into
spring-cloud:mainfrom
dileepharithasa:fix/Unsafe-StreamBridge-Cache-Implementation

Conversation

@dileepharithasa

Copy link
Copy Markdown

No description provided.

indentation changed in addition to teh fix given - Prevent concurrent channelCache access during shutdown and refresh
@dileepharithasa dileepharithasa changed the title Prevent concurrent channelCache access during shutdown and refresh Signed-off-by: Dileep Kumar Somajohassula dileepharithasa@gmail.com - Prevent concurrent channelCache access during shutdown and refresh Jun 14, 2026
@dileepharithasa

Copy link
Copy Markdown
Author

Hello @olegz and team,

Could you please review this PR when you have a chance?

This change prevents concurrent access to channelCache during application shutdown and refresh events by synchronizing cache cleanup operations with the existing lock used by destination resolution.

Thank you!

@dileepharithasa

Copy link
Copy Markdown
Author

Hello @olegz and team,

Could you please review this PR when you have a chance?

Thanks

@dileepharithasa

Copy link
Copy Markdown
Author

Hello @olegz @venilnoronha @trisberg @gabac @jvalkeal & team,

Could you please review this PR when you have a chance?

Thanks

@olegz

olegz commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

@dileepharithasa listing as many people as you can find demanding some type of action is counter productive. We are doing our best with resources that we have, so please don't do it moving forward.
Further more, i have reviewed this PR last week and left comments. Awaiting response.

@olegz

olegz commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Also, please fix your commit messages to fall in line with accepted practices. If you need additional guidance you can read this blog post https://medium.com/@iambonitheuri/the-art-of-writing-meaningful-git-commit-messages-a56887a4cb49

@olegz

olegz commented Jul 2, 2026

Copy link
Copy Markdown
Contributor

@dileepharithasa Are you planning to address the comments I have made?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants