Remove MC from Azure Appframework Tests (Phase 2)#1870
Draft
gabrielm-splunk wants to merge 3 commits intodevelopfrom
Draft
Remove MC from Azure Appframework Tests (Phase 2)#1870gabrielm-splunk wants to merge 3 commits intodevelopfrom
gabrielm-splunk wants to merge 3 commits intodevelopfrom
Conversation
gabrielm-splunk
force-pushed
the
remove-mc-azure-gcp-appframework-phase2
branch
from
3c9111c to
babfce8
Compare
Removes unnecessary Monitoring Console deployments from Azure appframework test suite (s1, m4, c3). MC is not the test subject in these tests, just an incidental deployment adding 4-9 minutes overhead per test. Changes: - Remove MC deployment sections (Azure uploads, app framework specs) - Remove MonitoringConsoleRef from CR specs - Pass empty string for mcRef parameters in deployment functions - Remove MC verification calls (VerifyMonitoringConsoleReady) - Remove MC app source info from verification arrays - Remove MC pod arrays from verification logic - Update test comments to remove MC references Files Modified: ✓ test/appframework_az/s1/appframework_azure_test.go - 746 lines removed ✓ test/appframework_az/m4/appframework_azure_test.go - 236 lines removed ✓ test/appframework_az/c3/appframework_azure_test.go - 81 lines removed ✓ test/appframework_az/c3/manager_appframework_azure_test.go - 66 lines removed Total: 1,129+ lines removed, all files compile successfully Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Removes remaining Monitoring Console code from the Azure M4 manager appframework test file to fully complete Phase 2. Changes: - Remove all MC upload sections (azTestDirMC) - Remove MC spec creation and deployment calls - Remove MC verification calls (VerifyMonitoringConsoleReady) - Remove MC from all app source info arrays - Update deployment calls to pass empty string for mcRef - Remove unused corev1 import - Fix variable declarations File: test/appframework_az/m4/manager_appframework_azure_test.go Lines removed: 106 lines (2517 → 2411) MC references remaining: 0 All Azure files now fully cleaned and compile successfully. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
gabrielm-splunk
force-pushed
the
remove-mc-azure-gcp-appframework-phase2
branch
from
931d95a to
c2196e2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Phase 2 of MC removal - Azure appframework tests cleaned. 1,129 lines removed across 4 files. All compile successfully. Estimated 2-3 hours test time savings.