[Phase 1] Remove Monitoring Console from AWS appframework tests

[gabrielm-splunk]

Summary

Remove unnecessary Monitoring Console deployments from AWS appframework tests to reduce test execution time and resource overhead.

Motivation

The Monitoring Console (MC) is deployed in every AWS appframework test but adds significant overhead without providing proportional testing value:

• Extra S3 uploads for MC apps
• Additional pod deployment and verification
• Increased test complexity and maintenance burden

Removing MC from these tests will:

• Reduce test execution time
• Lower resource consumption
• Simplify test code and maintenance
• Keep test focus on core app framework functionality

Changes

Files Modified (5 total, ~946 net lines removed)

S1 Tests (Standalone):

• test/appframework_aws/s1/appframework_aws_test.go - ~266 lines removed

M4 Tests (Multisite):

• test/appframework_aws/m4/appframework_aws_test.go - ~141 lines removed
• test/appframework_aws/m4/manager_appframework_test.go - ~172 lines removed

C3 Tests (Cluster):

• test/appframework_aws/c3/appframework_aws_test.go - ~194 lines removed
• test/appframework_aws/c3/manager_appframework_test.go - ~260 lines removed

Technical Changes

For each test file:

1. Removed MC S3 upload blocks
2. Removed MC spec creation and deployment calls
3. Removed MonitoringConsoleRef from CR specs (Standalone, ClusterManager, SearchHeadCluster)
4. Removed MC verification calls (VerifyMonitoringConsoleReady)
5. Removed MC pods and app source info from verification arrays
6. Updated allAppSourceInfo arrays to exclude MC entries

Verification

✅ All 5 modified files compile successfully:

ginkgo build ./appframework_aws/s1/ ./appframework_aws/m4/ ./appframework_aws/c3/
# All tests compile without errors

✅ Single commit on branch remove-mc-aws-phase1
✅ ~946 net lines removed (1032 deletions, 86 additions)
✅ No functional changes to CR deployment or app framework testing

Testing

• Compilation verified for all test files
• No changes to actual test logic, only MC-related code removed
• CR deployments (Standalone, ClusterManager, SearchHeadCluster) remain unchanged except for MC reference removal

Next Steps

• This is Phase 1: AWS tests only
• Phase 2 (future): Remove MC from Azure tests
• Phase 3 (future): Remove MC from GCP tests

Checklist

• All files compile successfully
• Single logical commit
• Clear commit message
• Changes match stated objective
• CI tests pass (pending)

🤖 Generated with Claude Code