reimplement: SHC_3BB0A8C1_0x0047BF20 register and structure issues#139
Draft
TheRedDaemon wants to merge 3 commits into
Draft
reimplement: SHC_3BB0A8C1_0x0047BF20 register and structure issues#139TheRedDaemon wants to merge 3 commits into
TheRedDaemon wants to merge 3 commits into
Conversation
gynt
reviewed
Jun 28, 2026
| namespace MSS { | ||
|
|
||
| typedef uint SoundFlagsAndLoopCount; | ||
| typedef int SoundFlagsAndLoopCount; |
Contributor
There was a problem hiding this comment.
Are you sure it is int? Some & operations naturally produce negative right-hand-sides if an int.
Contributor
Author
There was a problem hiding this comment.
It increased the matching and actually started producing the binary mask instead of just using a mov to a 16bit register.
But this function is another one of these annoying ones. A lot of branch optimization, gotos.
Always in the hope that there is a when: When we manage to match the function, I will try reverting this change and test around a bit.
If this goes through, all other methods need to be tested again, of course.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.