fix/batch-changes: validate files target paths in changeset hooks and executor#1352
Open
cbrnrd wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
src-clirejects commas in top-levelsteps.filestarget paths because a comma breaks out of Docker--mountsyntax and lets an attacker inject arbitrarysource=/target=pairs (e.g. mounting/var/run/docker.sock). That same validation was missing forchangesetHooks.*.steps[].files, so a malicious v3 batch spec could smuggle a dangerousfilestarget path through a hook and reach the executor-side Docker mount sink.The executor (
src batch exec) makes this worse: it loads already-parsedStepstructs from JSON and never re-runsParseBatchSpec/validateHooks, so parse-time validation alone is a coordinator-only guard.Solution
filestarget paths invalidateHooks(covers bothonCIFailureandonMergeConflict).createFilesToMount, so the check holds regardless of how a step reaches the executor.Verification Evidence