Conversation
jupblb
force-pushed
the
michal/lsif-removal
branch
4 times, most recently
from
f5346ff to
ec3d217
Compare
jupblb
force-pushed
the
michal/lsif-removal
branch
3 times, most recently
from
a803d3f to
6997803
Compare
Drop support for LSIF output format, keeping only typed SCIP output (.scip and .scip.ndjson). Deleted: - lsif.proto and generated types (LsifObject, LsifPosition, LsifHover, etc.) - SnapshotLsifCommand (was already deprecated) - MarkupContent, ResultIds, ResultSets, ScipByteOutputStream Simplified: - ScipOutputFormat: removed GRAPH_NDJSON/GRAPH_PROTOBUF - ScipWriter: removed LSIF graph emission methods, kept JSON serialization for .scip.ndjson - ScipOutputStream: simplified to raw byte writing with NDJSON newline handling - ScipSemanticdb: removed runGraph() code path - ScipSemanticdbOptions: LsifToolInfo -> Scip.ToolInfo, removed language/buildKind - PackageTable: removed ScipWriter dependency
jupblb
force-pushed
the
michal/lsif-removal
branch
from
6997803 to
0638840
Compare
chrapkowski-sg
approved these changes
Feb 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Drop support for LSIF output format, keeping only SCIP output (.scip).
Test plan
Existing tests pass