Skip to content

feat: use different application icon for debug builds #2495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
JC-Chung wants to merge 1 commit into
base: develop
Choose a base branch
from
+17 −3
Open

feat: use different application icon for debug builds #2495

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/App.axaml.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -257,6 +257,12 @@ public override void OnFrameworkInitializationCompleted()
e.Cancel = true;
});

#if DEV_BUILD
var devIcon = new WindowIcon(
Avalonia.Platform.AssetLoader.Open(new Uri("avares://SourceGit/AppDev.ico")));
Window.WindowOpenedEvent.AddClassHandler<Window>((w, _) => w.Icon = devIcon);
#endif

if (TryLaunchAsFileHistoryViewer(desktop))
return;

Expand Down
Binary file added src/AppDev.ico
View file
Open in desktop
Binary file not shown.
14 changes: 11 additions & 3 deletions src/SourceGit.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
<OutputType>WinExe</OutputType>
<TargetFramework>net10.0</TargetFramework>
<ApplicationManifest>App.manifest</ApplicationManifest>
<ApplicationIcon>App.ico</ApplicationIcon>
<Version>$([System.IO.File]::ReadAllText("$(MSBuildProjectDirectory)\\..\\VERSION"))</Version>
<AvaloniaUseCompiledBindingsByDefault>true</AvaloniaUseCompiledBindingsByDefault>
<SuppressTrimAnalysisWarnings>true</SuppressTrimAnalysisWarnings>
Expand All @@ -19,6 +18,14 @@
<RepositoryType>Public</RepositoryType>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Release'">
<ApplicationIcon>App.ico</ApplicationIcon>
</PropertyGroup>
<PropertyGroup Condition="'$(Configuration)' != 'Release'">
<ApplicationIcon>AppDev.ico</ApplicationIcon>
<DefineConstants>$(DefineConstants);DEV_BUILD</DefineConstants>
</PropertyGroup>

<PropertyGroup Condition="'$(Configuration)' == 'Release' and '$(DisableAOT)' != 'true'">
<PublishAot>true</PublishAot>
<PublishTrimmed>true</PublishTrimmed>
Expand All @@ -39,6 +46,7 @@

<ItemGroup>
<AvaloniaResource Include="App.ico" />
<AvaloniaResource Include="AppDev.ico" />
<AvaloniaResource Include="Resources/Fonts/*" />
<AvaloniaResource Include="Resources/Grammars/*" />
<AvaloniaResource Include="Resources/Images/*" />
Expand Down Expand Up @@ -71,11 +79,11 @@

<Target BeforeTargets="GetAssemblyAttributes" Name="GenVersionInfo">
<Exec Command="git describe --abbrev=8 --dirty" ConsoleToMsBuild="True" IgnoreExitCode="true">
<Output PropertyName="FriendlyVersion" TaskParameter="ConsoleOutput"/>
<Output PropertyName="FriendlyVersion" TaskParameter="ConsoleOutput" />
</Exec>

<ItemGroup>
<AssemblyMetadata Include="FriendlyVersion" Value="$([System.String]::Copy('$(FriendlyVersion)').Replace('g', '').Trim())"/>
<AssemblyMetadata Include="FriendlyVersion" Value="$([System.String]::Copy('$(FriendlyVersion)').Replace('g', '').Trim())" />
</ItemGroup>
</Target>
</Project>
Expand Down
Loading