fix(server): mergeProps silently drops keys that shadow Object.prototype methods#2800
Open
JSap0914 wants to merge 1 commit into
Open
fix(server): mergeProps silently drops keys that shadow Object.prototype methods#2800JSap0914 wants to merge 1 commit into
JSap0914 wants to merge 1 commit into
Conversation
…e methods
The server-side mergeProps in src/server/rendering.ts used
if (key in target) continue;
to skip keys already present on the result object. Because 'in'
walks the entire prototype chain, keys such as 'toString', 'valueOf',
and 'hasOwnProperty' were always found on the bare {} target via
Object.prototype, so those source properties were silently discarded.
The merged object then exposed the inherited Object.prototype method
instead of the value supplied by the caller.
Replace the 'in' check with Object.prototype.hasOwnProperty.call(target, key)
so only own properties already added to the result trigger a skip.
Add explicit early returns for '__proto__' and 'constructor' to match
the client-side mergeProps behaviour in src/render/component.ts.
Regression tests added to packages/solid/test/rendering.spec.ts.
🦋 Changeset detectedLatest commit: a5bcdea The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The server-side
mergePropsinsrc/server/rendering.tsused:to skip keys already added to the result object. Because
inwalks the prototype chain, every property inherited fromObject.prototype(toString,valueOf,hasOwnProperty, etc.) is always found on the plain{}target. This means any source with one of those keys as an own property is silently ignored, and the merged result exposes the inheritedObject.prototypemethod instead of the supplied value.The client-side implementation (
src/render/component.ts) does not have this bug because it iterates source keys explicitly and only skips"__proto__"and"constructor".Before:
After:
Fix
Replace
key in targetwithObject.prototype.hasOwnProperty.call(target, key)so only own properties already added to the result are skipped. Add explicit early returns for'__proto__'and'constructor'to match the client-side behavior.How did you test this change?
packages/solid/test/rendering.spec.tsthat import the server rendering module directlypnpm vitest run)