You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Currently we dont add any path in the _server route
What is the new behavior?
The extracted function name is now added eg _server/function-name
Other information
This approach however seems flaky because it depends on the way that the Tanstack server function plugin is extracting and then constructing the ids which is "filepath--function-name_query"
This looks like it is prone to change and does not provide guarantees.
I did see that Tankstack plugin does have the filename but seems like its not in the returned options so it might be stripped off somewhere or I missed it.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
This PR includes no changesets
When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types
@brenelz I haven't been following along as to where you are in removing Vinxi, cause that is where the issue is I believe. So might be best just to close this PR as I think it will be resolved with the current roadmap.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #1795
What is the current behavior?
Currently we dont add any path in the _server route
What is the new behavior?
The extracted function name is now added eg _server/function-name
Other information
This approach however seems flaky because it depends on the way that the Tanstack server function plugin is extracting and then constructing the ids which is "filepath--function-name_query"
This looks like it is prone to change and does not provide guarantees.
I did see that Tankstack plugin does have the filename but seems like its not in the returned options so it might be stripped off somewhere or I missed it.