refactor: adds centralized author map to streamline resource entries#552
Draft
thedanchez wants to merge 1 commit intosolidjs:mainfrom
Draft
refactor: adds centralized author map to streamline resource entries#552thedanchez wants to merge 1 commit intosolidjs:mainfrom
thedanchez wants to merge 1 commit intosolidjs:mainfrom
Conversation
Contributor
Author
|
@davedbase whenever you have time, curious to get your thoughts on this approach here to consolidate things a bit and reduce the amount of repeated field entries for the records in this file. |
339321c to
b7e5151
Compare
Member
|
Thanks so much for looking into this. The honest truth is that I was hoping to completely refactor this out of a JSON file. As the ecosystem is growing the file for storing this is growing, it makes more sense to put this in a different storage solution. For a while I was considering an API so that we can handle dynamic submissions and such. |
3a74baf to
a6bf7b8
Compare
7982d26 to
23f1ccb
Compare
23f1ccb to
f890d08
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactors the
Resourceentries underUtilities.data.tsto use new helper methods:packageByandlibraryBy.Those two helper methods are meant to reduce the amount of repetitive entries for the
author,author_urlandtypeper eachResourcerecord put into the list.I think I like this since it co-locates all the unique library authors into a single map struct so one can appreciate all the work done by said individuals for the Solid community instead of all of them being "lost in the sea of records"