Conversation
buffalojoec
left a comment
There was a problem hiding this comment.
Looks good, but two questions:
- Do we have it documented anywhere which commit/tag the MB pinocchio program is built from?
- Are you intentionally only adding fixtures and regression testing for p-token, or should we cover both?
Ah right, I forgot about adding that. I did the same as with ALT and config -- note that it's testing against the old mb token program.
I believe the repo is only currently running regression against p-token, so I just kept it to the existing behavior. I can certainly also run regression for the old version too, but since we'll never redeploy it, I don't think it's too valuable. |
|
Oh sorry, I also added the json versions of the fixtures in a separate commit -- do you think that's worth it? |
It doesn't hurt - although viewing the diff on that last commit crashed my GitHub. 😅 |
That's hilarious, command-line git was chugging on my personal machine on that commit 😅 |
Confirmed on command-line the last commit was all JSON. |
Problem
Unlike most of the other repos, we're still using package.json in the token repo.
Summary of changes
Move away from the scripts and into a Makefile with the reusable workflows instead.
This one's a bit different since we're adding the fixtures that were generated from mollusk, and using those as a normal "regression" step, as with the ALT and config programs.