Skip to content

repo: Use a Makefile#130

Merged
joncinque merged 12 commits intosolana-program:mainfrom
joncinque:makefile
Feb 26, 2026
Merged

repo: Use a Makefile#130
joncinque merged 12 commits intosolana-program:mainfrom
joncinque:makefile

Conversation

@joncinque
Copy link
Contributor

Problem

Unlike most of the other repos, we're still using package.json in the token repo.

Summary of changes

Move away from the scripts and into a Makefile with the reusable workflows instead.

This one's a bit different since we're adding the fixtures that were generated from mollusk, and using those as a normal "regression" step, as with the ALT and config programs.

@joncinque joncinque marked this pull request as ready for review February 26, 2026 12:07
Copy link
Contributor

@buffalojoec buffalojoec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but two questions:

  • Do we have it documented anywhere which commit/tag the MB pinocchio program is built from?
  • Are you intentionally only adding fixtures and regression testing for p-token, or should we cover both?

@joncinque
Copy link
Contributor Author

Do we have it documented anywhere which commit/tag the MB pinocchio program is built from?

Ah right, I forgot about adding that. I did the same as with ALT and config -- note that it's testing against the old mb token program.

Are you intentionally only adding fixtures and regression testing for p-token, or should we cover both?

I believe the repo is only currently running regression against p-token, so I just kept it to the existing behavior. I can certainly also run regression for the old version too, but since we'll never redeploy it, I don't think it's too valuable.

buffalojoec
buffalojoec previously approved these changes Feb 26, 2026
@joncinque
Copy link
Contributor Author

Oh sorry, I also added the json versions of the fixtures in a separate commit -- do you think that's worth it?

@buffalojoec
Copy link
Contributor

Oh sorry, I also added the json versions of the fixtures in a separate commit -- do you think that's worth it?

It doesn't hurt - although viewing the diff on that last commit crashed my GitHub. 😅

@joncinque
Copy link
Contributor Author

It doesn't hurt - although viewing the diff on that last commit crashed my GitHub. 😅

That's hilarious, command-line git was chugging on my personal machine on that commit 😅

@buffalojoec
Copy link
Contributor

It doesn't hurt - although viewing the diff on that last commit crashed my GitHub. 😅

That's hilarious, command-line git was chugging on my personal machine on that commit 😅

Confirmed on command-line the last commit was all JSON.

@joncinque joncinque merged commit dab16aa into solana-program:main Feb 26, 2026
26 checks passed
@joncinque joncinque deleted the makefile branch February 26, 2026 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants