Conversation
Member
grod220
commented
Feb 25, 2026
grod220
commented
- Gate all bytemuck derives behind a feature flag in spl-pod
- Set default = [] so consumers opt in to only the features they need
grod220
commented
Feb 25, 2026
grod220
commented
Feb 25, 2026
| bytemuck_derive = { version = "1.10.1", optional = true } | ||
| serde = { version = "1.0.228", optional = true, features = ["derive"] } | ||
| solana-address = { version = "2.2.0", features = ["bytemuck"] } | ||
| solana-address = { version = "2.2.0", features = ["copy"] } |
Member
Author
There was a problem hiding this comment.
Previously provided transitively by bytemuck feature, now needs it explicitly added
grod220
force-pushed
the
bytemuck-feature-flag
branch
from
21d48c2 to
50838e2
Compare
joncinque
reviewed
Feb 26, 2026
Contributor
joncinque
left a comment
joncinque
left a comment
There was a problem hiding this comment.
Looks great overall! Just the question on the Copy bound
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.