Remove obsolete version checks#4284
Open
m-bert wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes iOS/macOS version-gating in the native (Apple) implementation by raising the CocoaPods deployment targets and simplifying availability-guarded code paths accordingly.
Changes:
- Updated
RNGestureHandler.podspecto raise minimum deployment targets for iOS/tvOS/macOS. - Removed now-obsolete
@available(...)checks and compile-time SDK guards around APIs that are guaranteed by the new minimum targets. - Simplified hover/large-content-viewer/feedback logic to always execute on supported platforms.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/react-native-gesture-handler/RNGestureHandler.podspec | Raises Apple platform minimum deployment targets to match current support assumptions. |
| packages/react-native-gesture-handler/apple/RNGestureHandlerButtonComponentView.mm | Removes iOS 13 availability checks for large-content-viewer accessibility properties. |
| packages/react-native-gesture-handler/apple/RNGestureHandlerButton.mm | Makes hover recognizer setup and related helpers unconditional for supported iOS versions; simplifies macOS FPS query. |
| packages/react-native-gesture-handler/apple/Handlers/RNPanHandler.m | Removes iOS 13.4 gating for trackpad scroll-type configuration on pan recognizer. |
| packages/react-native-gesture-handler/apple/Handlers/RNHoverHandler.m | Removes SDK/version macro gating; keeps tvOS unsupported path while simplifying iOS hover setup. |
| packages/react-native-gesture-handler/apple/Handlers/RNHoverHandler.h | Removes API_AVAILABLE annotation now implied by the deployment target. |
| packages/react-native-gesture-handler/apple/Handlers/RNForceTouchHandler.m | Removes iOS 10 availability check for haptic feedback generator. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
j-piasecki
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR removes obsolete version checks from our
iOScodebase.Minimal targets for iOS and macOS were chosen based on supported versions. tvOS was changed to match iOS
Test plan
Checked that example apps (basic and macos) are built correctly,