Get uiRuntime directly from react-native-worklets#4276
Draft
coado wants to merge 4 commits into
Draft
Conversation
coado
changed the title
uiRuntime directly from react-native-worklets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The
uiRuntimeaddress is currently accessed through the Reanimated's global_WORKLET_RUNTIMEstored on the main JS thread. This diff changes that to firstly try accessing it using thegetUIWorkletRuntimefromreact-native-worklets( whenever worklets are found) and fallback to previous approach.Test plan
Tested on Runtime Decoration example on iOS and Android.