Skip to content

Fix Native gesture outside cancellation default #4239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
sorinc03 wants to merge 1 commit into
base: main
Choose a base branch
from
+1 −5
Draft

Fix Native gesture outside cancellation default #4239

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 1 addition & 5 deletions ...ndler/android/src/main/java/com/swmansion/gesturehandler/core/NativeViewGestureHandler.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,10 +43,6 @@ class NativeViewGestureHandler : GestureHandler() {

private var lastActiveUpdate: ActiveUpdateSnapshot? = null

init {
shouldCancelWhenOutside = true
}

override fun resetConfig() {
super.resetConfig()
shouldActivateOnStart = DEFAULT_SHOULD_ACTIVATE_ON_START
Comment on lines 43 to 48
Expand Down Expand Up @@ -226,7 +222,7 @@ class NativeViewGestureHandler : GestureHandler() {
}

companion object {
private const val DEFAULT_SHOULD_CANCEL_WHEN_OUTSIDE = true
private const val DEFAULT_SHOULD_CANCEL_WHEN_OUTSIDE = false
private const val DEFAULT_SHOULD_ACTIVATE_ON_START = false
private const val DEFAULT_DISALLOW_INTERRUPTION = false
Comment on lines +225 to 227
private const val DEFAULT_YIELDS_TO_CONTINUOUS_GESTURES = false
Expand Down
Loading